🚀 ♻️ build-system: merge unminified and vendor codepath#35419
Merged
samouri merged 3 commits intoampproject:mainfrom Aug 13, 2021
Merged
🚀 ♻️ build-system: merge unminified and vendor codepath#35419samouri merged 3 commits intoampproject:mainfrom
samouri merged 3 commits intoampproject:mainfrom
Conversation
Member
Author
|
Getting a real error, investigating now: |
Member
Author
|
Isolated the bug to reuse of the options object. This didn't matter because with separate codepaths the extra params were ignored in unminified builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
compileJsWithEsbuild-->esbuildCompile(similar to closureCompile).esbuildCompilefor unminified builds