Wrap preact.Fragment with preact.createElement#35418
Merged
caroqliu merged 2 commits intoampproject:mainfrom Jul 29, 2021
Merged
Wrap preact.Fragment with preact.createElement#35418caroqliu merged 2 commits intoampproject:mainfrom
caroqliu merged 2 commits intoampproject:mainfrom
Conversation
jridgewell
approved these changes
Jul 27, 2021
kristoferbaxter
approved these changes
Jul 27, 2021
developit
approved these changes
Jul 28, 2021
|
Might also be worth considering having this return function Fragment(props) {
return props.children;
} |
Contributor
Author
Thanks for the recommendation, updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
preact.Fragmentis a function,react.Fragmentis not. This PR nests withpreact.createElementto account for remappingpreact->react. Fixes #35412. Related to #35678