🚀 [Story performance] Disable animations in first page under experiment#35356
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
left a comment
There was a problem hiding this comment.
Please report the experiment to the CSI pipeline otherwise we can't collect data
| 'story-load-first-page-only' | ||
| ); | ||
| } | ||
| if (isExperimentOn(this.win, 'story-disable-animations-first-page')) { |
There was a problem hiding this comment.
Some thoughts on this:
- The experiment needs to be enabled for CSI tracking BEFORE the LCP metric is sent. Is it the case here?
- There are more cases where the animations are disabled (prefers-reduced-motion), I think it'd be interesting to capture this as well
There was a problem hiding this comment.
Good Qs
For 1: This is added on the buildCallback of a story (which happens before layoutStory_()), so it should happen before the LCP metric is sent.
For 2: We can trigger the CSI flag if prefers-reduced-motion is enabled, since that will also "disable animations on the first page". I don't think it'd be accurate if some of the users that have the reduced motion activated count towards this flag being OFF.
There was a problem hiding this comment.
have you tested (1) or is it working thanks to the render service?
There was a problem hiding this comment.
Tested it, it works
There's multiple ways LCP can get affected by animations on the first page:
There could potentially be more causes for LCP problems through animations, which is why we'll disable the animations on the first page. Launching the experiment for
5%