🚀 🚀 esbuild for production builds 🚀 🚀 #35201
Closed
samouri wants to merge 2 commits intoampproject:mainfrom
Closed
🚀 🚀 esbuild for production builds 🚀 🚀 #35201samouri wants to merge 2 commits intoampproject:mainfrom
samouri wants to merge 2 commits intoampproject:mainfrom
Conversation
2ea53aa to
6057246
Compare
525f92a to
05fb023
Compare
dbd8b76 to
a0a165a
Compare
659b649 to
1bf28cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Migrates from
closuretoesbuild/babel/terserfor the production builds (amp dist).The code in this PR is a POC, and there is likely much more cleanup/deletion that we could pursue if we decide to land this.
Changes:
terser's mangle property mode, specifically for vars that end with an underscore. This is fairly dangerous, and only works because of two disabled optimizations (compress.properties,mangle.properties.keep_quoted).