✨[amp-analytics] Session Count for Session Analytics#34850
Merged
micajuine-ho merged 15 commits intoampproject:mainfrom Jun 23, 2021
Merged
✨[amp-analytics] Session Count for Session Analytics#34850micajuine-ho merged 15 commits intoampproject:mainfrom
micajuine-ho merged 15 commits intoampproject:mainfrom
Conversation
added 11 commits
May 25, 2021 14:32
f924ced to
57a9665
Compare
alanorozco
approved these changes
Jun 22, 2021
| updateSession_(session) { | ||
| if (isSessionExpired(session)) { | ||
| const newSessionCount = | ||
| session.count === undefined ? 1 : session.count + 1; |
Member
There was a problem hiding this comment.
In which cases would session.count be undefined?
Contributor
Author
There was a problem hiding this comment.
Only in the rare case of a user using session analytics before this PR comes out.
ba8bddc to
234f5f6
Compare
234f5f6 to
6b0b3c6
Compare
Contributor
Author
|
cc @ampproject/wg-performance Can I get a approval for bundle size check? |
rcebulko
reviewed
Jun 23, 2021
| /** | ||
| * @param {SessionInfoDef|string} storedSession | ||
| * @return {SessionInfoDef|undefined} | ||
| * @param {*} storedSession |
Contributor
There was a problem hiding this comment.
When might this be of a different type?
Contributor
Author
There was a problem hiding this comment.
That's the type we get back from storage-impl/get(). I imagine it has to do with the fact that we can't guarantee that no one will tamper with LS.
rcebulko
approved these changes
Jun 23, 2021
Contributor
rcebulko
left a comment
There was a problem hiding this comment.
left a couple comments but approving for bundle-size
Co-authored-by: Ryan Cebulko <ryan@cebulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #33990