✨[amp-form] Allow form attributes for form elements outside of amp-form#34849
Closed
micajuine-ho wants to merge 7 commits intoampproject:mainfrom
Closed
✨[amp-form] Allow form attributes for form elements outside of amp-form#34849micajuine-ho wants to merge 7 commits intoampproject:mainfrom
micajuine-ho wants to merge 7 commits intoampproject:mainfrom
Conversation
added 5 commits
June 1, 2021 15:57
… of `amp-form` (ampproject#33095)" This reverts commit be956c9.
… outside of `amp-form` (ampproject#33095)"" This reverts commit 6f134d7.
|
Hey @ampproject/wg-caching! These files were changed: |
zhangsu
approved these changes
Jun 12, 2021
honeybadgerdontcare
approved these changes
Jun 13, 2021
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation change
Member
|
@micajuine-ho what's the state of this PR. Is it still being worked on? |
|
Micajuine Ho seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32447
Follow up to
formattributes for form elements outside… #34640form[custom-validation-reporting="as-you-go"]#34682PR consists of
formattributes for form elements outside ofamp-form#33095)changetwice instead ofinput)