✅ Add e2e test for form[custom-validation-reporting="as-you-go"]#34679
Closed
alanorozco wants to merge 0 commit intoampproject:mainfrom
Closed
✅ Add e2e test for form[custom-validation-reporting="as-you-go"]#34679alanorozco wants to merge 0 commit intoampproject:mainfrom
form[custom-validation-reporting="as-you-go"]#34679alanorozco wants to merge 0 commit intoampproject:mainfrom
Conversation
|
Hey @estherkim! These files were changed: |
alanorozco
commented
Jun 3, 2021
build-system/tasks/e2e/e2e-types.js
Outdated
| 'ArrowLeft': 'ArrowLeft', | ||
| 'ArrowRight': 'ArrowRight', | ||
| 'ArrowUp': 'ArrowUp', | ||
| 'Backspace': 'Backspace', |
Member
Author
There was a problem hiding this comment.
Necessary to trigger a backspace. I don't like this double mapping :(
micajuine-ho
approved these changes
Jun 3, 2021
Contributor
micajuine-ho
left a comment
There was a problem hiding this comment.
Thank you for adding this test Alan!!
| await controller.click(submitButton); | ||
| await expect( | ||
| 'https://example.com/subscribe?__amp_source_origin=http%3A%2F%2Flocalhost%3A8000' | ||
| ).to.not.have.been.sent; |
Contributor
There was a problem hiding this comment.
Curious, this check for a request being sent is natively built into our testing framework?
Member
Author
There was a problem hiding this comment.
Only on e2e tests.
extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js:
102 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=sufficient'
103: ).to.have.been.sent;
extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side-expire-cache.js:
47 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=insufficient'
48: ).to.have.been.sent;
92 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=sufficient'
93: ).to.have.been.sent;
extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js:
85 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=insufficient'
86: ).to.have.been.sent;
extensions/amp-form/0.1/test-e2e/test-validation-reporting-as-you-go.js:
36 'https://example.com/subscribe?__amp_source_origin=http%3A%2F%2Flocalhost%3A8000'
37: ).to.not.have.been.sent;
38 });
48 'https://example.com/subscribe?__amp_source_origin=http%3A%2F%2Flocalhost%3A8000'
49: ).to.have.been.sent;
extensions/amp-video/0.1/test-e2e/test-amp-video-analytics.js:
53 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking&id=myVideo'
54: ).to.have.been.sent;
64 'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking&id=myVideo2'
65: ).to.have.been.sent;
extensions/amp-video/0.1/test-e2e/test-amp-video-flexible-bitrate.js:
228 'https://amp-dev.cdn.ampproject.org/mbv/s/amp.dev/static/samples/video/tokyo.mp4?amp_video_host_url=https%3A%2F%2Famp.dev%2F&__amp_source_origin=http%3A%2F%2Flocalhost%3A8000'
229: ).to.have.been.sent;
caroqliu
approved these changes
Jun 3, 2021
estherkim
approved these changes
Jun 3, 2021
build-system/tasks/e2e/e2e-types.js
Outdated
| 'ArrowLeft': 'ArrowLeft', | ||
| 'ArrowRight': 'ArrowRight', | ||
| 'ArrowUp': 'ArrowUp', | ||
| 'Backspace': 'Backspace', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test case related to #34641, which should fail with a rollforward.