🏗 Enable type-checking for performance and get-zindex#34661
Merged
rsimha merged 2 commits intoampproject:mainfrom Jun 3, 2021
rsimha:2021-06-02-PerformanceTypeCheck
Merged
🏗 Enable type-checking for performance and get-zindex#34661rsimha merged 2 commits intoampproject:mainfrom rsimha:2021-06-02-PerformanceTypeCheck
performance and get-zindex#34661rsimha merged 2 commits intoampproject:mainfrom
rsimha:2021-06-02-PerformanceTypeCheck
Conversation
|
Hey @rileyajones! These files were changed: |
build-system/tasks/performanceperformance and get-zindex
Contributor
Author
|
Adding reviewers based on recent edits:
|
rileyajones
approved these changes
Jun 3, 2021
Contributor
rileyajones
left a comment
There was a problem hiding this comment.
This looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Highlights:
build-system/tasks/performance/build-system/tasks/get-zindexWith this, there are zero pending directories for which type-checking needs to be enabled.
Future work:
Fixes #28387