✨ [amp-story] [amp-story-page-outlink] Element child#34532
Merged
processprocess merged 45 commits intoampproject:mainfrom Jun 2, 2021
Merged
✨ [amp-story] [amp-story-page-outlink] Element child#34532processprocess merged 45 commits intoampproject:mainfrom
processprocess merged 45 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
Gregable
requested changes
May 26, 2021
Member
Gregable
left a comment
There was a problem hiding this comment.
Review for validator changes only. Does not imply that the semantics of the change are OK.
… experiment is off.
gmajoulet
reviewed
May 26, 2021
examples/visual-tests/amp-story/amp-story-page-attachment-v2.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
mszylkowski
approved these changes
Jun 1, 2021
Gregable
approved these changes
Jun 1, 2021
gmajoulet
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Fixes #34507
demo
Paste
AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true)into the console to activate the experiment.Updates
amp-story-page-outlinkto use an anchor child instead of anhrefattribute.Outlink navigation is triggered by a programatic click on this tag to be fully compliant with all analytics or other tracking mechanisms.
amp-story-page-outlink.cta-textfrom validation in favor ofa's text content.titlefrom validation in favor of childa's title attribute.hreffrom validation in favor of childa's href attribute.REMOTEtoOUTLINKinAttachmentTypeenum to keep semantics consistent.amp-story-page-attachment[href].