♻️ Extract json helpers to core/types/object/json#34367
Merged
rcebulko merged 15 commits intoampproject:mainfrom May 14, 2021
Merged
♻️ Extract json helpers to core/types/object/json#34367rcebulko merged 15 commits intoampproject:mainfrom
rcebulko merged 15 commits intoampproject:mainfrom
Conversation
|
Hey @erwinmombay! These files were changed: Hey @jridgewell! These files were changed: Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: Hey @alanorozco! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: Hey @processprocess! These files were changed: Hey @Enriqe! These files were changed: |
alanorozco
approved these changes
May 13, 2021
rcebulko
commented
May 13, 2021
| @@ -0,0 +1,351 @@ | |||
| /** | |||
Contributor
Author
There was a problem hiding this comment.
This was moved from test/unit/core/types/test-object.js
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
| * Copyright 2021 The AMP HTML Authors. All Rights Reserved. | |||
Contributor
Author
There was a problem hiding this comment.
GH doesn't show this, but this file was moved to src/core/object/types/json.js (which has the 2015 copyright date) and this file is "new"
danielrozenberg
approved these changes
May 13, 2021
Member
danielrozenberg
left a comment
There was a problem hiding this comment.
Approval for build-system/*
calebcordry
approved these changes
May 13, 2021
jridgewell
requested changes
May 13, 2021
rcebulko
commented
May 13, 2021
jridgewell
reviewed
May 13, 2021
This was referenced Nov 5, 2021
This was referenced Jan 18, 2022
Closed
Closed
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the diff to review: 2179341...54ada92
Everything else is just updating import statements.
Part of #32693
Also they pass type-checking now