🏗 [bento] Add portals to preact compat#33213
Merged
krdwan merged 2 commits intoampproject:masterfrom Mar 17, 2021
Merged
Conversation
caroqliu
reviewed
Mar 12, 2021
src/preact/compat.js
Outdated
|
|
||
| /** | ||
| * @param {PreactDef.VNode} vnode | ||
| * @param {Element} container |
Contributor
There was a problem hiding this comment.
I see the Preact.createPortal takes a PreactElement type for container which extends HTMLElement. I don't think our PreactDef has anything like PreactElement, @jridgewell should we add this to our externs, use HTMLElement, or is this ok as is?
Contributor
There was a problem hiding this comment.
HTMLElement is fine. They use PreactElement so they can attach private props to the element, but we don't need to know about that.
23 tasks
alanorozco
approved these changes
Mar 16, 2021
jridgewell
approved these changes
Mar 17, 2021
src/preact/compat.js
Outdated
|
|
||
| /** | ||
| * @param {PreactDef.VNode} vnode | ||
| * @param {Element} container |
Contributor
There was a problem hiding this comment.
HTMLElement is fine. They use PreactElement so they can attach private props to the element, but we don't need to know about that.
caroqliu
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add portals to preact/compat for use in Bento components