Fix displaying hero images over blurry image placeholder#32806
Merged
jridgewell merged 2 commits intoampproject:masterfrom Feb 23, 2021
Merged
Fix displaying hero images over blurry image placeholder#32806jridgewell merged 2 commits intoampproject:masterfrom
jridgewell merged 2 commits intoampproject:masterfrom
Conversation
This change allows us to immediately display SSR images when they load, even if this occurs before JS load (or JS fails to load). Before, these images would be stuck behind the blurry image placeholder due to the z-index stacking.
sebastianbenz
approved these changes
Feb 22, 2021
Contributor
sebastianbenz
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
jridgewell
commented
Feb 22, 2021
caroqliu
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows us to immediately display SSR images when they load, even if this occurs before JS load (or JS fails to load). Before, these images would be stuck behind the blurry image placeholder due to the z-index stacking.
Fixes #32387