✨ [bento][amp-sidebar] Add warning when sidebar not child of body (amp mode only)#31835
Merged
krdwan merged 3 commits intoampproject:masterfrom Jan 12, 2021
Merged
✨ [bento][amp-sidebar] Add warning when sidebar not child of body (amp mode only)#31835krdwan merged 3 commits intoampproject:masterfrom
krdwan merged 3 commits intoampproject:masterfrom
Conversation
dvoytenko
approved these changes
Jan 7, 2021
caroqliu
reviewed
Jan 7, 2021
Contributor
caroqliu
left a comment
There was a problem hiding this comment.
Code LGTM, had a question about location.
caroqliu
approved these changes
Jan 7, 2021
c11631d to
d1c605c
Compare
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar tracker: #31366
When sidebar is not a direct child of body, throw a warning to the user.
todo: add tests