🖍 [bento][amp-sidebar] Allow various CSS properties to be configurable on amp-sidebar#31628
Merged
krdwan merged 9 commits intoampproject:masterfrom Jan 11, 2021
Merged
Conversation
krdwan
commented
Dec 16, 2020
23 tasks
dvoytenko
suggested changes
Dec 16, 2020
krdwan
commented
Dec 18, 2020
| height: '100vh', | ||
| top: 0, | ||
| maxHeight: '100vh', | ||
| maxWidth: '80vw', |
Contributor
Author
There was a problem hiding this comment.
Removed !important from maxHeight, maxWidth, minWidth here. This allows user to overwrite by specifying amp-sidebar { selector (which is lower specificity than class selector). (for amp mode)
Opinons?
krdwan
commented
Dec 18, 2020
caroqliu
reviewed
Jan 5, 2021
caroqliu
approved these changes
Jan 5, 2021
dvoytenko
suggested changes
Jan 7, 2021
dvoytenko
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/15
Overview of PR:
styleandbackdropStyleprops. To have the style included inline in the rendered element.12/18
To do:
Add feature to customize colors in amp-sidebar
To change these in amp mode include the following css:
To change these in preact mode include the following props:
Open Questions:
amp-sidebar::part(sidebar))Answer: no, the current is an existing pattern, see: https://jsbin.com/nawecap/edit?html,css,output