✨ [bento][amp-sidebar] Initial AMP Component#31593
Merged
krdwan merged 6 commits intoampproject:masterfrom Dec 16, 2020
Merged
Conversation
krdwan
commented
Dec 14, 2020
| } | ||
|
|
||
| /** @override */ | ||
| mutationObserverCallback() { |
Contributor
Author
There was a problem hiding this comment.
Allow opening / closing of sidebar by adding / removing the open attribute on amp-sidebar element.
krdwan
commented
Dec 14, 2020
| </Sidebar> | ||
| <div style={{marginTop: 8}}> | ||
| <br /> | ||
| <button onClick={() => ref.current.toggle()}>toggle</button> |
Contributor
Author
There was a problem hiding this comment.
Removed this to match style of other Storybooks (i.e. Lightbox)
f510d7c to
1090a29
Compare
This was referenced Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial: #31366
Initial AMP Component of amp-sidebar
Todo: tests