Turn on closure compiler collapse properties.#2972
Turn on closure compiler collapse properties.#2972cramforce merged 1 commit intoampproject:masterfrom
Conversation
test/size.txt
Outdated
There was a problem hiding this comment.
On it. Need to run gulp clean Takes a while.
There was a problem hiding this comment.
The metrics are correct, though.
8ed844f to
0f23987
Compare
|
@cramforce still seeing the disconnect i was seeing in #2951 with collapsProperties on v0.js (which is why i excluded it). didnt want to merge it and break testing for everybody |
03cc053 to
4a0d9c4
Compare
|
Alright, excited to see what travis says. Worked around the |
Boom. The only apparent problem was related to handling of the default export from PJs, which needed both some local changes and a version bump for PJS.
4a0d9c4 to
fe5e298
Compare
|
Green build :) |
|
@cramforce LGTM! |
|
This will need some baking :) |
|
@cramforce good timing since we're only doing canary next week |
|
+1 On Fri, Apr 22, 2016 at 5:58 PM, erwin mombay notifications@github.com
|
| 70.67 kB | 10.21 kB | 3.95 kB | v0/amp-vine-0.1.js | ||
| 81.63 kB | 13.23 kB | 4.91 kB | v0/amp-youtube-0.1.js | ||
| 135.66 kB | 36.85 kB | 12.34 kB | current-min/f.js / current/integration.js No newline at end of file | ||
| 614.81 kB | 157.73 kB | 43.68 kB | v0.js / amp.js |
There was a problem hiding this comment.
Looking good here if the results are stable. ~9% reduction.
Boom.