Append ad iframe _after_ registering listeners#2942
Merged
erwinmombay merged 1 commit intoampproject:masterfrom Apr 19, 2016
Merged
Append ad iframe _after_ registering listeners#2942erwinmombay merged 1 commit intoampproject:masterfrom
erwinmombay merged 1 commit intoampproject:masterfrom
Conversation
When the ad's iframe is already cached, we can end up running it's code before we register our event listeners on it. That really stinks for ads, because they need to send a `render-start` event to us for us to show them and we're not even listening for it when they send. :sadpanda:
Member
|
Great catch! LGTM |
Contributor
|
wow!! please add an assert on iframe_helper to warn when this happens! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ad's iframe is already cached, we can end up running it's code
before we register our event listeners on it. That really stinks for
ads, because they need to send a
render-startevent to us for us toshow them and we're not even listening for it when they send. :sadpanda:
Fixes #2933.