✨Convert the full-width responsive to container-width responsive for desktop users.#28565
Merged
calebcordry merged 10 commits intoampproject:masterfrom May 29, 2020
Merged
Conversation
|
Hey @jeffkaufman! These files were changed: |
Member
Author
|
Screenshot: |
calebcordry
reviewed
May 27, 2020
extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
Outdated
Show resolved
Hide resolved
calebcordry
reviewed
May 27, 2020
jridgewell
reviewed
May 27, 2020
calebcordry
reviewed
May 28, 2020
21086e4 to
9da3f75
Compare
…, and add comments for parentElement & clientWidth to avoid BUILD complains.
…lignToViewport at the end to make CSS adjustment
2db4bc9 to
4a9b46b
Compare
jridgewell
reviewed
May 29, 2020
calebcordry
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementations for issue: #28403. Convert the full-width responsive to container-width responsive for desktop users.
PTAL. @charliereams, @calebcordry, @jridgewell