amp-consent iframe ui 100% height#28290
Merged
micajuine-ho merged 3 commits intoampproject:masterfrom May 11, 2020
Merged
Conversation
added 2 commits
May 6, 2020 15:04
Contributor
Author
|
/cc @MaximePlancke I believe this fixes your issue, but if you could create a jsbin with an example that is similar to https://sandbox.didomi.io/amp.html, I can test and ensure that it fixes it. |
zhouyx
approved these changes
May 8, 2020
Contributor
zhouyx
left a comment
There was a problem hiding this comment.
Thank you for the investigation and fix!
Contributor
|
@micajuine-ho thank you! Sure, is this ok? https://jsbin.com/vawekakina/1/edit?html,output I tried on my end with your changes on Xcode and it seems to fix the issue. |
Contributor
Author
|
Tested and it fixes it. Thanks for the jsbin. |
Contributor
|
Do you know when this change will be part of the stable release? I saw that it was but has been rolled back 23 days ago. Thank you! |
Contributor
Author
|
Hi @MaximePlancke this change is in stable. Are you not seeing a fix? |
Contributor
|
My bad, I see it now. I got confused with the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28133.
Based on https://developers.google.com/web/updates/2016/12/url-bar-resizing (
This means 100vh will be larger than the visible height when the URL bar is shown...For example, if its height is 100% it will always fill exactly the visible height, whether or not the URL bar is shown.), we should be using 100% instead of 100vh.Retains the changes made in #20100
