Add support for Ad Up Technology ads#2779
Add support for Ad Up Technology ads#2779SteffenAnders wants to merge 1 commit intoampproject:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! Company: Ad Up Technology AG |
ads/aduptech.js
Outdated
|
@SteffenAnders Looks good. Just a couple of small requests. It looks like you may also need to rebase. |
|
|
@SteffenAnders Code and tests look good. Please rebased to the newest master as described in the https://help.github.com/articles/about-git-rebase/ |
cf8708e to
763a3df
Compare
|
done |
c516eff to
31ea609
Compare
|
@SteffenAnders I'm afraid there's another merge conflict. Could you please rebase again? |
ca14e2f to
1607b23
Compare
|
@dvoytenko rebased again :) |
|
@SteffenAnders Apologies, but it looks like there was quite a queue of PRs on these files. Could you please rebase to newest master one more time? I'll make sure your PR goes in as soon as it has no conflicts. |
|
@dvoytenko rebased to newest master :) |
|
landed as 394eb0c |
Add support for Ad Up Technology ads