Skip to content

Add support for Ad Up Technology ads#2779

Closed
SteffenAnders wants to merge 1 commit intoampproject:masterfrom
adup-archive:adup_ads
Closed

Add support for Ad Up Technology ads#2779
SteffenAnders wants to merge 1 commit intoampproject:masterfrom
adup-archive:adup_ads

Conversation

@SteffenAnders
Copy link
Copy Markdown
Contributor

Add support for Ad Up Technology ads

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SteffenAnders
Copy link
Copy Markdown
Contributor Author

I signed it!

Company: Ad Up Technology AG
Google Group: ad-up-technology-ag@googlegroups.com
E-Mail: steffen.anders@adup-tech.com

ads/aduptech.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct to 2016.

@dvoytenko
Copy link
Copy Markdown
Contributor

@SteffenAnders Looks good. Just a couple of small requests. It looks like you may also need to rebase.

@SteffenAnders
Copy link
Copy Markdown
Contributor Author

@dvoytenko

  • add support for layout=responsive
  • fixed requests
  • rebased to master

@dvoytenko
Copy link
Copy Markdown
Contributor

@SteffenAnders Code and tests look good.

Please rebased to the newest master as described in the https://help.github.com/articles/about-git-rebase/

@SteffenAnders SteffenAnders force-pushed the adup_ads branch 2 times, most recently from cf8708e to 763a3df Compare April 5, 2016 14:05
@SteffenAnders
Copy link
Copy Markdown
Contributor Author

@dvoytenko

done

@SteffenAnders SteffenAnders force-pushed the adup_ads branch 2 times, most recently from c516eff to 31ea609 Compare April 6, 2016 07:11
@dvoytenko
Copy link
Copy Markdown
Contributor

@SteffenAnders I'm afraid there's another merge conflict. Could you please rebase again?

@SteffenAnders SteffenAnders force-pushed the adup_ads branch 2 times, most recently from ca14e2f to 1607b23 Compare April 7, 2016 14:02
@SteffenAnders
Copy link
Copy Markdown
Contributor Author

@dvoytenko rebased again :)

@dvoytenko
Copy link
Copy Markdown
Contributor

@SteffenAnders Apologies, but it looks like there was quite a queue of PRs on these files. Could you please rebase to newest master one more time? I'll make sure your PR goes in as soon as it has no conflicts.

@dvoytenko dvoytenko added the LGTM label Apr 7, 2016
@SteffenAnders
Copy link
Copy Markdown
Contributor Author

@dvoytenko rebased to newest master :)

@erwinmombay
Copy link
Copy Markdown
Member

landed as 394eb0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants