build-system: Restrict allowed version_override#27687
Merged
kristoferbaxter merged 1 commit intoampproject:masterfrom Apr 10, 2020
Merged
build-system: Restrict allowed version_override#27687kristoferbaxter merged 1 commit intoampproject:masterfrom
kristoferbaxter merged 1 commit intoampproject:masterfrom
Conversation
Version must be 13 digits. Combined with a 2-digit config code, this implies RTVs must be 15 digits. Fixes ampproject#27579
Contributor
Author
|
@ampproject/wg-infra |
jridgewell
approved these changes
Apr 10, 2020
|
|
||
| // Allow leading zeros in --version_override, e.g. 0000000000001 | ||
| const argv = minimist(process.argv.slice(2), { | ||
| string: ['version_override'], |
Contributor
There was a problem hiding this comment.
I think this is unnecessary. minimist should parse --version_override whatever as version_override: 'whatever' by default.
Contributor
Author
There was a problem hiding this comment.
It is necessary. I only added it after testing.
rcebulko
reviewed
Apr 10, 2020
| return String(argv.version_override); | ||
| const version = String(argv.version_override); | ||
| // #27579: What are allowed version strings...? | ||
| if (!/^\d{13}$/.test(version)) { |
Contributor
There was a problem hiding this comment.
Nit: Pull the version regex out into a constant for easier updating
Contributor
There was a problem hiding this comment.
Agree here, but lets get this in and follow up with the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version must be 13 digits. Combined with a 2-digit config code, this
implies RTVs must be 15 digits.
Fixes #27579