amp-app-banner: Support apple-itunes-app lookup in AmpDocShadow#27346
Merged
alanorozco merged 1 commit intoampproject:masterfrom Mar 27, 2020
Merged
amp-app-banner: Support apple-itunes-app lookup in AmpDocShadow#27346alanorozco merged 1 commit intoampproject:masterfrom
alanorozco merged 1 commit intoampproject:masterfrom
Conversation
33 tasks
alanorozco
approved these changes
Mar 27, 2020
Member
alanorozco
left a comment
There was a problem hiding this comment.
Thanks for doing this.
Are there other cases for meta[name] lookups that would make sense to change to use this API?
Contributor
Author
See #26652 . It's nearly complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query meta[name="apple-itunes-app"] using method supported by
AmpDocShadow as well as other AmpDoc subtypes.