🐛 Create image pixel in onload event handler of iframe#27204
Merged
rcebulko merged 3 commits intoampproject:masterfrom Mar 12, 2020
Merged
🐛 Create image pixel in onload event handler of iframe#27204rcebulko merged 3 commits intoampproject:masterfrom
rcebulko merged 3 commits intoampproject:masterfrom
Conversation
zhouyx
suggested changes
Mar 12, 2020
zhouyx
approved these changes
Mar 12, 2020
jridgewell
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #23935 (comment)
Addresses the fourth and soon-to-be* third most frequent unexpected error logged to AMP Error Reporting.
The soon-to-be part is because error volume has skyrocketed due to a very large news publisher updating their site in a way that triggers this race condition all the time. It's only been live for a day or so right now and only on Beta/Experimental, but based on that slice of traffic it's set to outpace almost all other reported errors.
I expect this to eliminate approximately 1 million error reports per week, based on the frequency of these two errors in Beta/Experimental
Closes #23935
Closes #27207