🚀 Move timezoneCode macro from url-replacement-impl#26896
Merged
micajuine-ho merged 2 commits intoampproject:masterfrom Feb 25, 2020
Merged
🚀 Move timezoneCode macro from url-replacement-impl#26896micajuine-ho merged 2 commits intoampproject:masterfrom
micajuine-ho merged 2 commits intoampproject:masterfrom
Conversation
7 tasks
d815424 to
70f97f3
Compare
zhouyx
approved these changes
Feb 21, 2020
| 'SOURCE_URL', | ||
| 'TIMESTAMP', | ||
| 'TIMEZONE', | ||
| 'TIMEZONE_CODE', |
Contributor
There was a problem hiding this comment.
We should definitely remove the variable from the allowed list so it won't get initialized below. However the list also serves as a documentation on what is supported in the a4a environment. Maybe we should host such a document list somewhere else, or add a comment here.
Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Tracker: #26091
Moving timezoneCode macro to amp-analytics.
(Was previously #25597)