✨[amp-story-player] Adds navigation logic#26751
Merged
Enriqe merged 8 commits intoampproject:masterfrom Feb 19, 2020
Merged
Conversation
gmajoulet
reviewed
Feb 12, 2020
Contributor
gmajoulet
left a comment
There was a problem hiding this comment.
Could you add some basic tests? :))
5cc6a2b to
bc3b6c3
Compare
Contributor
Author
|
PTAL |
gmajoulet
reviewed
Feb 14, 2020
Contributor
gmajoulet
left a comment
There was a problem hiding this comment.
Just some small nits, it's looking good, LGTM otherwise :))
Contributor
Author
|
Adding @samouri for owners approval (as suggested by the bot). |
96af6ff to
60524bb
Compare
60524bb to
1900844
Compare
Contributor
Author
|
PTAL @gmajoulet |
gmajoulet
approved these changes
Feb 19, 2020
samouri
approved these changes
Feb 19, 2020
Member
samouri
left a comment
There was a problem hiding this comment.
Approving just the src/owners file.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26696
Tracker #26308