amp-analytics: Support amp-google-client-id-api lookup in AmpDocShadow#26683
Merged
mdmower merged 2 commits intoampproject:masterfrom Feb 11, 2020
Merged
amp-analytics: Support amp-google-client-id-api lookup in AmpDocShadow#26683mdmower merged 2 commits intoampproject:masterfrom
mdmower merged 2 commits intoampproject:masterfrom
Conversation
- Read meta[name="i-amphtml-access-state"] using method supported by AmpDocShadow as well as other AmpDoc subtypes. - Tag <body> with i-amphtml-linker-created in ShadowRoot since <meta> element does not exist.
33 tasks
Query meta[name="amp-google-client-id-api"] using method supported by AmpDocShadow as well as other AmpDoc subtypes.
micajuine-ho
approved these changes
Feb 10, 2020
Contributor
micajuine-ho
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta[name="amp-google-client-id-api"]using method supported byAmpDocShadowas well as otherAmpDocsubtypes.<body>withi-amphtml-linker-createdinAmpDocShadowsince<meta>element does not exist.