♻️ Remerge: Resources/Mutator service refactor#26638
♻️ Remerge: Resources/Mutator service refactor#26638powerivq merged 1 commit intoampproject:masterfrom
Conversation
2570481 to
10f57ac
Compare
10f57ac to
484ea46
Compare
484ea46 to
de5accc
Compare
|
Once you are back and able. This PR is ready to be merged. @choumx @estherkim |
|
Does this PR contain any changes other than a roll-forward of #26479?
Do we know why this was and did we fix the root cause? |
|
@choumx It does not contain anything else.
The reason is that |
Oh I see, the element used in amp-auto-lightbox.js didn't have the right type. To catch these kinds of bugs in the future, we'd need a warning system for underspecified types. Please file an issue for this and reference it in your cherry-pick post-mortem (#26483). |
|
@choumx make sense! created an issue. |
This PR would merge back the PR reverted for causing amp-auto-lightbox to fail. Since
.getResources()call caused type check not be able to find out the type mismatch, I have again searched for all references to this method and found no other use of it.