✨<amp-next-page> v2 default and templated footers (more articles box)#26610
Merged
wassgha merged 10 commits intoampproject:masterfrom Feb 11, 2020
Merged
✨<amp-next-page> v2 default and templated footers (more articles box)#26610wassgha merged 10 commits intoampproject:masterfrom
wassgha merged 10 commits intoampproject:masterfrom
Conversation
16 tasks
alanorozco
reviewed
Feb 7, 2020
| buildDefaultFooter_() { | ||
| const html = htmlFor(this.getHost_()); | ||
| return html` | ||
| <div class="amp-next-page-footer" aria-label="Read more articles"></div> |
Member
There was a problem hiding this comment.
What happens with i18n for this aria-label?
Contributor
Author
There was a problem hiding this comment.
Blocked by #4146 I don't think there's a nice way to do it so far. Lightbox and carousel controls do the same.
Member
There was a problem hiding this comment.
Let's expose this as an optional data-read-more-label then.
alanorozco
requested changes
Feb 7, 2020
alanorozco
reviewed
Feb 11, 2020
alanorozco
reviewed
Feb 11, 2020
alanorozco
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes