♻️ test-performance.js: differentiate between relative and absolute time.#26568
Merged
samouri merged 3 commits intoampproject:masterfrom Jan 31, 2020
Merged
♻️ test-performance.js: differentiate between relative and absolute time.#26568samouri merged 3 commits intoampproject:masterfrom
samouri merged 3 commits intoampproject:masterfrom
Conversation
Member
|
from what i recall it should be time relative to epoch, ill try and figure out the original intention of that test (its been a while) |
erwinmombay
approved these changes
Jan 30, 2020
jridgewell
approved these changes
Jan 31, 2020
Contributor
jridgewell
left a comment
There was a problem hiding this comment.
Excellent test updates.
Member
Author
|
Thanks all for the quick reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
lolexto simulateDate.now()to begin at 100 instead of at 0. When it was 0, it became impossible to test the difference between relative and absolute time (value vs. delta)