Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Hi @zhouyx , don't hesitate if you have any question on this one :)

Hello @dav-m85. Thanks for integrating with AMP!

I ran your example locally, but got the following error. Could you please take a look

Thanks.

Also FYI we've recently changed our fullScreen API, and it's only supported with user interaction. please refer to #26197 for more information on that change. Thank you

@zhouyx fair enough, we were fixing server endpoints. It should be good now :)

I think we are already complying with the new fullscreen api, we call it only when the user interacts with the controls inside the iframe. Should be good, but don't hesitate to ping me if I'm wrong.

@dav-m85 thanks for the PR. Looks great, PR merged. The change should ship in pre-release next week, and in prod a week after that. more information on the release schedule https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md

Also, this PR should be automatically updating with labels "In Release: Experimental/Beta/Stable/LTS" as it makes it into various release builds.

Joly good! Thanks for this quick review and update 🥇

I am wondering why the check-links check didn't catch the dead link https://github.com/ampproject/amphtml/master/extensions/amp-consent/cmps/appconsent.md

cc @rsimha @estherkim idea? Thanks!

@zhouyx Filed an issue to track. Thanks for reporting!