📖 amp-consent fullscreen restriction documentation#26487
Merged
micajuine-ho merged 5 commits intoampproject:masterfrom Feb 12, 2020
Merged
📖 amp-consent fullscreen restriction documentation#26487micajuine-ho merged 5 commits intoampproject:masterfrom
micajuine-ho merged 5 commits intoampproject:masterfrom
Conversation
9 tasks
Contributor
|
is this ready to merge? |
Contributor
Author
No, waiting for #26467 to get merged first |
zhouyx
approved these changes
Feb 11, 2020
| ``` | ||
|
|
||
| Action `'enter-fullscreen'` requests the AMP runtime to expand the iframe to fullscreen. | ||
| Action `'enter-fullscreen'` requests the AMP runtime to expand the iframe to fullscreen. `amp-consent` will only allow the iframe enter fullscreen if it detects user interaction within iframe (e.g. clicking on the iframe). |
Contributor
There was a problem hiding this comment.
technically it's user interaction with the iframe, impossible to detect interaction within the iframe : )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 5 of #26432
Added documentation of new restriction on fullscreen API