Skip to content

✨ <amp-next-page> v2 default and templated separator elements#26413

Merged
wassgha merged 29 commits intoampproject:masterfrom
wassgha:amp-next-page-v2separators
Jan 31, 2020
Merged

✨ <amp-next-page> v2 default and templated separator elements#26413
wassgha merged 29 commits intoampproject:masterfrom
wassgha:amp-next-page-v2separators

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Jan 20, 2020 •
edited
Loading

Screenshot

Screen Shot 2020-01-20 at 10 59 19 AM

Changes

  • Implements an improved default UI for the separator pill (delimiting the end of an article and the start of the next) as designed here.
  • Implements templating for custom separator elements which provides the title, url and image of the next article. Example:
<div separator class="amp-next-page-default-separator">
     <template type="amp-mustache">
          <div class="separator-content">
            <amp-img src={{image}} layout="fixed" height="16" width="16"></amp-img>
            <span>Next article: {{title}}</span>
          </div>
    </template>
</div>

Todo

  • Add unit tests

wassgha added 18 commits December 18, 2019 22:15
@wassgha
Added visual diff tests and better manual tests
2c60f47
@wassgha
Prototyping sticky element handling in amp-next-page
fd8de0d
@wassgha
Merge branch 'master' into amp-next-page-v2-hide-elements
5733c3e
@wassgha
Merge branch 'master' into amp-next-page-v2-visual-diff
35c9f61
@wassgha
Deprecate amp-next-page-keep in favor of amp-next-page-hidden
bac73c6
@wassgha
Visibility bug fix
8295a33
@wassgha
Remove animation added for testing
bf9e8a6
@wassgha
Exported host-page-specific parameters into HostPage
2085a36
@wassgha
Merge branch 'master' into amp-next-page-v2-hide-elements
aca949b
@wassgha
Preventing next-page form building again
72ce30f
@wassgha
Merge branch 'master' into amp-next-page-v2-visual-diff
3c38550
@wassgha
Remove visual diff tests
d12c8c6
@wassgha
Merge branch 'amp-next-page-v2-visual-diff' into amp-next-page-v2-inf…
0a35078 
…inite-loading
@wassgha
Implement infinite loading for amp-next-page v2
81a3e93
@wassgha
Merge branch 'master' into amp-next-page-v2-infinite-loading
63b4407
@wassgha
Implements un-loading and re-loading pages to reduce memory footprint
8065574
@wassgha
Added unit tests
3959e56
@wassgha
Fixes types
6fb9245
@wassgha wassgha requested a review from caroqliu January 20, 2020 19:05
@wassgha wassgha force-pushed the amp-next-page-v2separators branch from 0a39ed3 to 6a55cff Compare January 20, 2020 20:07
@wassgha wassgha marked this pull request as ready for review January 21, 2020 23:47
@wassgha wassgha requested a review from alanorozco January 24, 2020 01:34
@wassgha
Copy link
Copy Markdown
Contributor Author

wassgha commented Jan 24, 2020

/cc @alanorozco @caroqliu this one should be ready now :)

@wassgha wassgha mentioned this pull request Jan 24, 2020
Merged
@wassgha wassgha force-pushed the amp-next-page-v2separators branch from 8625b5a to 4c182f8 Compare January 24, 2020 05:43
caroqliu
caroqliu requested changes Jan 28, 2020
View reviewed changes
@wassgha wassgha requested a review from caroqliu January 29, 2020 06:14
@wassgha wassgha merged commit e7a8e7f into ampproject:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caroqliu caroqliu caroqliu approved these changes

@alanorozco alanorozco Awaiting requested review from alanorozco

Assignees

No one assigned

Labels

cla: yes PR use: In Beta / Experimental PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wassgha @caroqliu @googlebot @ampprojectbot