🏗️ Update transform-amp-asserts to leave devAsserts#26357
Merged
jridgewell merged 2 commits intomasterfrom Jan 15, 2020
Merged
Conversation
This is necessary for Closure to correctly narrow the type of the value. If we were to remove the `devAssert(foo)` call, then closure would not be able to tell that `foo` is truthy. This doesn't matter for `assertBoolean`/`assertString`/etc because we're able to replace the call with a typecast. There is no associated "truthy" cast possible for `devAssert`. Same for `dev().assert()`
rsimha
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for Closure to correctly narrow the type of the value.
If we were to remove the
devAssert(foo)call, then closure would not be able to tell thatfoois truthy. This doesn't matter forassertBoolean/assertString/etc because we're able to replace the call with a typecast. There is no associated "truthy" cast possible fordevAssert. Same fordev().assert()