Skip to content

✨Implement infinite article loading on amp-next-page v2#26296

Merged
wassgha merged 20 commits intoampproject:masterfrom
wassgha:amp-next-page-v2-infinite-loading
Jan 23, 2020
Merged

✨Implement infinite article loading on amp-next-page v2#26296
wassgha merged 20 commits intoampproject:masterfrom
wassgha:amp-next-page-v2-infinite-loading

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Jan 10, 2020

Changes

  • Implements infinite loading of articles from parsed amp-next-page configuration on child pages (while avoiding loops)
  • Implements unloading and reloading of pages to free up memory once the user scrolls too far away from a page
  • Fixes some types + minor cleanup
  • Implement unit tests for the changes

@amp-owners-bot
Copy link
Copy Markdown

Hey @ampproject/wg-caching, these files were changed:

  • validator/validator-main.protoascii

@wassgha wassgha force-pushed the amp-next-page-v2-infinite-loading branch from 765f672 to 63b4407 Compare January 15, 2020 19:03
@wassgha wassgha requested a review from caroqliu January 17, 2020 16:57
@wassgha wassgha marked this pull request as ready for review January 17, 2020 16:58
@wassgha wassgha requested review from alanorozco and removed request for honeybadgerdontcare January 21, 2020 21:43
Copy link
Copy Markdown
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few questions. Great work on this!

@wassgha wassgha force-pushed the amp-next-page-v2-infinite-loading branch from a64afba to 202ed6d Compare January 22, 2020 22:19
@wassgha wassgha requested a review from caroqliu January 23, 2020 00:27
Copy link
Copy Markdown
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!

@wassgha wassgha merged commit 6a7c345 into ampproject:master Jan 23, 2020
@wassgha wassgha deleted the amp-next-page-v2-infinite-loading branch January 23, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants