Closed
Conversation
7 tasks
zhouyx
reviewed
Jan 8, 2020
| return Services.performanceFor(win).getMakeBodyVisible(); | ||
| }); | ||
|
|
||
| this.setAsync('AMP_STATE', key => { |
Contributor
There was a problem hiding this comment.
want to confirm with @choumx that this is fine.
Do we see AMP_STATE used in other cases except analytics pings? form request maybe.
There was a problem hiding this comment.
This was originally added for AoG which uses amp-state extensively. E.g. might be used for forms or other data endpoints as you suggest.
I'm not sure if it's actively used today though. We can add a dev().expectedError to find usage.
Contributor
Author
There was a problem hiding this comment.
SG, will revisit after we collect some data on its usage.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Tracker: #26091
Moving AMP_STATE macro to amp-analytics
Edit: AMP_STATE is being used more than we realized. We will leave it as is.