✨Handling sticky, fixed and hidden elements in amp-next-page v2#26106
Merged
wassgha merged 8 commits intoampproject:masterfrom Jan 13, 2020
Merged
✨Handling sticky, fixed and hidden elements in amp-next-page v2#26106wassgha merged 8 commits intoampproject:masterfrom
amp-next-page v2#26106wassgha merged 8 commits intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
a31055c to
3a9b3b6
Compare
3a9b3b6 to
fd8de0d
Compare
0ab97c0 to
5733c3e
Compare
15f4f69 to
8295a33
Compare
Member
|
Validator changes look good, especially since they are just a comment change. |
caroqliu
requested changes
Jan 7, 2020
Contributor
caroqliu
left a comment
There was a problem hiding this comment.
Nice job! Don't forget to add unit tests and update the documentation file with the new attributes.
caroqliu
reviewed
Jan 8, 2020
Contributor
caroqliu
left a comment
There was a problem hiding this comment.
This looks a lot more readable and clear now, thanks!
caroqliu
approved these changes
Jan 10, 2020
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
amp-next-pagev1 fixed elements will no longer be hidden by default, they will however be constrained to their document's bounds (they won't overflow beyond the document's borders when the document is not visible).amp-next-page-hide, andamp-next-page-replace:amp-next-page-hideamp-next-page-replaceDemo page: Demo Site