Skip to content

cl/286269591 AMP respect different varieties of lightning bolt.#26094

Merged
Gregable merged 1 commit intoampproject:masterfrom
honeybadgerdontcare:validator-20191218-2
Dec 19, 2019
Merged

cl/286269591 AMP respect different varieties of lightning bolt.#26094
Gregable merged 1 commit intoampproject:masterfrom
honeybadgerdontcare:validator-20191218-2

Conversation

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor

Fixes #25990

  • cl/286269591 AMP respect different varieties of lightning bolt.

@Gregable Gregable merged commit 9690e80 into ampproject:master Dec 19, 2019
@honeybadgerdontcare honeybadgerdontcare deleted the validator-20191218-2 branch December 19, 2019 00:41
@samouri
Copy link
Copy Markdown
Member

samouri commented Dec 19, 2019

Does this cover all lightning bolt variations or just two?

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor Author

Does this cover all lightning bolt variations or just two?

It covers the previously invalid one in the initial issue and in the linked article. Allowing this solves an issue MacOS users were facing. If you'd like more, then you can reopen the issue and list them for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMP should respect ⚡️ apart from ⚡

5 participants