Move mutator interfaces to a separate service#25296
Closed
powerivq wants to merge 1 commit intoampproject:masterfrom
Closed
Move mutator interfaces to a separate service#25296powerivq wants to merge 1 commit intoampproject:masterfrom
powerivq wants to merge 1 commit intoampproject:masterfrom
Conversation
31b7ec9 to
5f1351a
Compare
01b7e7d to
fba17df
Compare
fba17df to
0d66374
Compare
|
Hey @gmajoulet, these files were changed:
Hey @newmuis, these files were changed:
|
c18bbef to
c617e95
Compare
c617e95 to
2edc325
Compare
lannka
reviewed
Nov 23, 2019
| /** | ||
| * Schedules the work pass at the latest with the specified delay. | ||
| */ | ||
| schedulePassVsync() {} |
Contributor
There was a problem hiding this comment.
@dvoytenko I'm wondering why we have schedulePass & schedlePassVsync. why do we need to batch in 2 different ways?
Contributor
There was a problem hiding this comment.
At this point it might be unnecessary. Initially this code likely dealt with inconsistencies with multi-browser event/rAF scheduling.
Contributor
There was a problem hiding this comment.
Got it, created a clean up task to track: #25793
lannka
approved these changes
Nov 23, 2019
Contributor
lannka
left a comment
There was a problem hiding this comment.
please do some manual testing with extensions that uses mutators in different environments.
This was referenced Dec 5, 2019
This was referenced Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the implementation of mutator functions into a separate service. Behaviors that are different are:
I believe it is okay, because all mutation requests start from mutator-impl. If mutator is not loaded, this logic should be a no-op anyways, so it does not alter the behavior.
Added new public interfaces to resources-interface that are intended to be used by mutator only for the sake of refactoring. Plz take a look at that. It also is the cause of the bundle size increase.
How should we deal with InaboxMutator? Do we want to run an experiment? I splitted InaboxResources as well, should it be kept on a separate PR?
Maybe it is also a good idea to move changes to use resources to mutator in a separate PR?