✨ Add amp-wordpress-embed component#24952
✨ Add amp-wordpress-embed component#24952westonruter wants to merge 34 commits intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation changes look good, just need current year in licenses
| @@ -0,0 +1,2 @@ | |||
| - westonruter | |||
| - amedina | |||
There was a problem hiding this comment.
Please use the JSON format for all new OWNERS files. This will become:
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example
{
rules: [
{
owners: [
{ name: "westonruter" },
{ name: "amedina" }
]
}
]
}There was a problem hiding this comment.
Also, /cc @kristoferbaxter in case he thinks we should add ampproject/wg-ui-and-a11y as an owner
rcebulko
left a comment
There was a problem hiding this comment.
Approving OWNERS changes
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation changes look good
|
Is this PR ready to go in? |
|
No, still on our radar to finish. Most likely to be picked up toward end of Q3. |
|
|
|
@westonruter is this PR still active? |
|
No. Now that Bento is underway, it'll need to be rewritten to make use of the new APIs anyway. |
Previously #18412.
Fixes #18378.
To test the component in the WordPress plugin, use the branch in this PR: ampproject/amp-wp#3465
Todo
linkmessage.placeholder.fallbackis supported. It should be ablockquote.overflowso that when the resize is rejected, we can show a button.placeholderworks.listenFormay not be right.secret?