Stop iOS 13 from elastically horizontally scrolling documents#24269
Merged
dvoytenko merged 6 commits intoampproject:masterfrom Aug 28, 2019
Merged
Stop iOS 13 from elastically horizontally scrolling documents#24269dvoytenko merged 6 commits intoampproject:masterfrom
dvoytenko merged 6 commits intoampproject:masterfrom
Conversation
lannka
reviewed
Aug 28, 2019
Contributor
|
should we further reduce the scope so it only happens in Viewer context? not sure which class is relevant, but we have: we might even add a class indicating it's safari? |
Contributor
Author
|
@lannka So, I'm really conscious introducing more differences between embedded and non-embedded cases. Most folk develop/test for a non-iframed case, so those deltas often come as a surprise. Same with Chrome vs Safari. |
Contributor
|
I thought you want to scope down. Are we confident that this new CSS will not break valid use cases? |
jridgewell
approved these changes
Aug 28, 2019
jridgewell
reviewed
Aug 28, 2019
jridgewell
reviewed
Aug 28, 2019
lannka
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #23379.
Fix for b/140131460.