🐛Change loader code to no longer add a default placeholder.#23971
Merged
wassgha merged 2 commits intoampproject:masterfrom Aug 15, 2019
Merged
🐛Change loader code to no longer add a default placeholder.#23971wassgha merged 2 commits intoampproject:masterfrom
wassgha merged 2 commits intoampproject:masterfrom
Conversation
Instead, create the background as part of the as a part of the loader element itself. This makes sure the background is removed when the loader is removed. This avoids an issue where the placeholder appears on top of an <amp-img> if the image finishes downloading before the loaders code runs.
wassgha
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, create the background as part of the as a part of the loader
element itself. This makes sure the background is removed when the
loader is removed.
This avoids an issue where the placeholder appears on top of an
<amp-img>if the image finishes downloading before the loaders coderuns.
Closes #23964