Remove @suppress in custom-element.js#23877
Merged
dreamofabear merged 6 commits intoampproject:masterfrom Aug 13, 2019
Merged
Conversation
powerivq
approved these changes
Aug 9, 2019
Contributor
|
Thanks @choumx Scanning through the codebase, there are few other places that suppresses checkType presumably for the same reason. Working on some others. |
jridgewell
approved these changes
Aug 9, 2019
Contributor
|
cool! thanks for the quick fix |
Author
|
This is causing single-pass build to DCE Lines 121 to 125 in 687ea08 Investigating. |
Contributor
|
amphtml/extensions/amp-mustache/0.2/amp-mustache.js Lines 33 to 37 in b8b12cc @choumx there is usage of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables stronger type checking in custom-element.js by removing
@suppressand@thisannotations. I think these were originally needed on an older version of Closure compiler.Fixed a few type errors that this caught and verified that this would've caught #23858.
/to @lannka @powerivq