Fix amp-date-picker closure compiler warnings#23806
Merged
cvializ merged 1 commit intoampproject:masterfrom Aug 8, 2019
Merged
Fix amp-date-picker closure compiler warnings#23806cvializ merged 1 commit intoampproject:masterfrom
cvializ merged 1 commit intoampproject:masterfrom
Conversation
sparhami
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23429
It turns out the solution was to make Closure Compiler stop checking the
extendsand to use ES5 class syntax with manual prototype chaining. Not ideal, but at least it's an established pattern that works.