Various micro optimizations of the component boot flow.#23767
Merged
cramforce merged 5 commits intoampproject:masterfrom Aug 7, 2019
Merged
Various micro optimizations of the component boot flow.#23767cramforce merged 5 commits intoampproject:masterfrom
cramforce merged 5 commits intoampproject:masterfrom
Conversation
701b0ab to
2384159
Compare
jridgewell
reviewed
Aug 7, 2019
src/service.js
Outdated
| return top; | ||
| } | ||
| // Make this defined but null to speed up future lookups. | ||
| win.__AMP_TOP = null; |
Contributor
There was a problem hiding this comment.
We could set this to win instead? Then keep the same ||: win.__AMP_TOP || (win.__AMP_TOP = win)
Member
Author
|
PTAL |
kristoferbaxter
approved these changes
Aug 7, 2019
jridgewell
approved these changes
Aug 7, 2019
This was referenced Jul 2, 2020
This was referenced Oct 10, 2020
This was referenced Oct 25, 2020
This was referenced Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasAttributescall frompropagateAttributesclassList.addoperations into one.getTopWindowfunction faster by ensuring the property that is rarely defined is at least known.