🐛 Use source relative URLs in navigateTo#23698
Merged
jridgewell merged 2 commits intoampproject:masterfrom Aug 6, 2019
Merged
Conversation
lannka
reviewed
Aug 5, 2019
| 'https://cdn.ampproject.org/c/s/www.pub.com/dir/page.html'; | ||
| const urlService = Services.urlForDoc(doc.documentElement); | ||
|
|
||
| sandbox.stub(urlService, 'getSourceUrl').callsFake(url => { |
Contributor
There was a problem hiding this comment.
shall we just install urlService to avoid this stub? that makes the test more robust to any future refactoring.
Contributor
Author
There was a problem hiding this comment.
I'm not sure I follow. urlService is already installed on the amp doc. I chose to stub the method because the internal anchor tag it uses is tied to the test runner's URL, not the fake window we'd expect.
Contributor
There was a problem hiding this comment.
i thought it would read from the fake URL you just set in L638?
dreamofabear
approved these changes
Aug 6, 2019
dreamofabear
left a comment
There was a problem hiding this comment.
Tangent: how close are we to removing parseUrlDeprecated? We've been in limbo awhile.
Contributor
Author
|
Planning on working on it a bit this week. |
lannka
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22376.