Abstract draggable drawer component.#23696
Merged
gmajoulet merged 1 commit intoampproject:masterfrom Aug 6, 2019
Merged
Conversation
Enriqe
approved these changes
Aug 6, 2019
724df3b to
6028a61
Compare
6028a61 to
c88a32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the "draggable" part of the
amp-story-page-attachmentcomponent to an abstract AMP component meant to be re-used.amp-story-page-attachmentnow simply extends this abstractamp-story-draggable-drawerclass, and overrides:buildCallbackto add specific header items (title + close button)Part 1/2 for #13833