🐛 Fix percentage-played when loadedmetadata fires before listener is added#22872
Merged
cvializ merged 4 commits intoampproject:masterfrom Jun 17, 2019
Merged
🐛 Fix percentage-played when loadedmetadata fires before listener is added#22872cvializ merged 4 commits intoampproject:masterfrom
cvializ merged 4 commits intoampproject:masterfrom
Conversation
alanorozco
reviewed
Jun 17, 2019
| // If the video has already emitted LOADEDMETADATA, the event below | ||
| // will never fire, so we check if it's already available here. | ||
| if (this.hasDuration_()) { | ||
| this.calculate_(this.triggerId_); |
Member
There was a problem hiding this comment.
Maybe we don't need to listen for LOADEDMETADATA in this case?
Contributor
Author
There was a problem hiding this comment.
oh good point, I'll try that
zhouyx
approved these changes
Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22701
@alanorozco do you think this will work or are there any concerns with this approach?