Revert third_party/subscriptions-project/ files for Closure upgrade#21827
Merged
rsimha merged 1 commit intoampproject:masterfrom Apr 11, 2019
Merged
Revert third_party/subscriptions-project/ files for Closure upgrade#21827rsimha merged 1 commit intoampproject:masterfrom
rsimha merged 1 commit intoampproject:masterfrom
Conversation
rsimha
approved these changes
Apr 11, 2019
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Approving. Sorry I made this change to third_party/subscriptions. The reason I did so was because of this rule:
amphtml/build-system/tasks/presubmit-checks.js
Lines 562 to 569 in 613b5e2
Turns out that third_party/subscriptions is exempt from the rule.
I'll merge this as soon as gulp presubmit goes green with this change.
Contributor
|
Presubmit checks are green with this change: https://travis-ci.org/ampproject/amphtml/jobs/518910154#L331-L335 It's safe to merge this PR. |
This was referenced May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted from #21618.