Skip to content

✨amp-recaptcha-input: Removed experiment from amp-recaptcha-input#21664

Merged
torch2424 merged 1 commit intoampproject:masterfrom
torch2424:amp-recaptcha-input-remove-experiment
Apr 2, 2019
Merged

✨amp-recaptcha-input: Removed experiment from amp-recaptcha-input#21664
torch2424 merged 1 commit intoampproject:masterfrom
torch2424:amp-recaptcha-input-remove-experiment

Conversation

@torch2424
Copy link
Copy Markdown
Contributor

closes #2273

This removes the experiment for amp-recaptcha-input. Thus launching this feature, and making this available to the public! 😄

This should be approved before April 8th, 2019, and merged on April 8th, 2019. In order to line up with a certain date 👀

Also, this should have a paired documentation update to inform users the feature is no longer experimental 😄 After this goes live in PROD (to avoid confusion).

Example

Screen Shot 2019-04-01 at 3 25 09 PM

@torch2424 torch2424 requested a review from zhouyx April 1, 2019 22:36
@torch2424
Copy link
Copy Markdown
Contributor Author

torch2424 commented Apr 2, 2019

Per @aghassemi suggestion, this should actually be merged for today's release, in order to ensure that this is in prod for the certain date. In case of a revert 😄

@torch2424
Copy link
Copy Markdown
Contributor Author

Thank you @aghassemi ! 😄 Merging...

@torch2424 torch2424 merged commit 4a26197 into ampproject:master Apr 2, 2019
@torch2424 torch2424 deleted the amp-recaptcha-input-remove-experiment branch April 2, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support reCAPTCHA component

3 participants