✨🏗 [WIP] Upgrade closure compiler to v20181210#20056
Closed
rsimha wants to merge 7 commits intoampproject:masterfrom
rsimha:2018-12-21-ClosureUpgrade
Closed
✨🏗 [WIP] Upgrade closure compiler to v20181210#20056rsimha wants to merge 7 commits intoampproject:masterfrom rsimha:2018-12-21-ClosureUpgrade
rsimha wants to merge 7 commits intoampproject:masterfrom
rsimha:2018-12-21-ClosureUpgrade
Conversation
Contributor
Author
|
Closing this since the code has significantly deviated since this PR was created. Also, @erwinmombay is working on a way to eliminate the custom built |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Still testing.
Partial fix for #18748
Follow up to #18552
Follow up to #18609
Follow up to #18794